Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toggle to disable ProgressPlugin #3185

Closed
wants to merge 1 commit into from

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Nov 17, 2016

This patch adds a command line option that can disable the Webpack ProgressPlugin, keeping it enabled by default.

Disabling this progress speeds up the initial build that ng serve does quite significantly in our setup, where we use pm2 to start ng serve.

The build process of our app went down from about 25 to 11 seconds.

Please let me know if it needs any adjustments to get merged.

This patch adds a command line option that can disable the Webpack
ProgressPlugin, keeping it enabled by default
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@beeman
Copy link
Contributor Author

beeman commented Nov 18, 2016

@googlebot I signed it!

Company name is Fullcube

@clydin
Copy link
Member

clydin commented Nov 18, 2016

There's already a PR for this: #2858; Although it appears to have stalled.

@beeman
Copy link
Contributor Author

beeman commented Nov 18, 2016

You're right @clydin, didn't check for it.

It seems like the other PR adds more functionality, I'm personally only interested in hiding the progress.

@hansl
Copy link
Contributor

hansl commented Nov 23, 2016

We're looking into these 2 PRs, not sure yet what we're going to do. We're mostly interested in the claim that

The build process of our app went down from about 25 to 11 seconds.

That's a huge difference that should not be only explained by the progress plugin, so we're really curious.

Note: Just as an FYI, if we decide to go with this PR we're going to ask you to sign the CLA.

@beeman
Copy link
Contributor Author

beeman commented Nov 23, 2016

@hansl we see this performance gain in one of our apps. We run this app inside a Docker container, as a process in pm2. It's probably the way pm2 outputs the progress that makes it so much slower.

If it helps I can create a demo that shows the behavior.

Re: the CLA, I should have signed it. Is it not visible?

@googlebot
Copy link

CLAs look good, thanks!

@hansl
Copy link
Contributor

hansl commented Nov 23, 2016

It is now. You have to comment here for the CLA bot to check again.

@filipesilva
Copy link
Contributor

Superseded by #2858, which is now updated.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants